[PATCH] D42024: [WebAssembly] Create synthetic __dso_handle symbol

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 16 14:45:56 PST 2018


sbc100 added a comment.

In https://reviews.llvm.org/D42024#977637, @ruiu wrote:

> I'm not opposing to this patch, but I wonder if this is the best way of doing what you want to do in the new file format. We define __dso_handle symbol for ELF because the existing code expects the symbol. But since we don't have such existing code in wasm (am I correct?) I wonder if there's a different way.


We do have existing code that depends on __dso_handle in that clang will generate calls to  __cxa_atexit() passing __dso_handle as the third arg (see clang/lib/CodeGen/ItaniumCXXABI.cpp).


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D42024





More information about the llvm-commits mailing list