[PATCH] D42075: [WebAssembly] Symbol changes #1, LLVM

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added a comment.

I think dropping the debug names from the symbol table seems like a good idea.
I'm not so sure about dropping the the imports from the name section.   It seems at least like a separate change.
I like added requirement on the section ordering, although I'd prefer a more explicit way to check for it.

What do you think about dropping the name section completely from the compiler output?  If the compiler output is meant mainly as a linker input perhaps we don't need a names section at all (since its arguably redundant in the face of the symbol table stuff).



================
Comment at: lib/Object/WasmObjectFile.cpp:273
   llvm::DenseSet<uint64_t> Seen;
+  if (Functions.size() != FunctionTypes.size()) {
+    return make_error<GenericBinaryError>("Names must come after code section",
----------------
Seems like an odd way to verify this, but I can't think of a better one of the top of my head.


Repository:
  rL LLVM

https://reviews.llvm.org/D42075