[PATCH] D41954: [WebAssembly] Symbol changes #5: add "symbol index" concept (LLVM)

[Nicholas Wilson via Phabricator via llvm-commits]

ncw marked 3 inline comments as done.
ncw added inline comments.


================
Comment at: test/MC/WebAssembly/global-ctor-dtor.ll:162
 ; CHECK-NEXT:         Flags:           [ BINDING_LOCAL ]
+; CHECK-NEXT:       - Name:            __dso_handle
+; CHECK-NEXT:         Flags:           [ BINDING_WEAK, VISIBILITY_HIDDEN ]
----------------
Updated test expectations: some benign reordering of iteration now means that globals come after functions.


================
Comment at: test/MC/WebAssembly/weak-alias.ll:66
 ; CHECK-NEXT:             Initial:         0x00000001
-; CHECK-NEXT:       - Module:          env
-; CHECK-NEXT:         Field:           foo_alias
-; CHECK-NEXT:         Kind:            FUNCTION
-; CHECK-NEXT:         SigIndex:        0
-; CHECK-NEXT:       - Module:          env
-; CHECK-NEXT:         Field:           bar_alias
-; CHECK-NEXT:         Kind:            GLOBAL
-; CHECK-NEXT:         GlobalType:      I32
-; CHECK-NEXT:         GlobalMutable:   false
 ; CHECK-NEXT:   - Type:            FUNCTION
 ; CHECK-NEXT:     FunctionTypes:   [ 0, 0, 0, 0, 0 ]
----------------
Updated test expectations: getting rid of these imports that duplicate the exports is exactly what we were trying to achieve!

The consequence is that all the function/global indexes below have been decremented by 1 - except for index zero (foo_alias) which is now 5. Each index change below matches my expectations.


Repository:
  rL LLVM

https://reviews.llvm.org/D41954