[PATCH] D42010: [LLD][COFF] Report error when file will exceed Windows maximum image size (4GB)

[Reid Kleckner via Phabricator via llvm-commits]

rnk added inline comments.


================
Comment at: tools/lld/COFF/Writer.cpp:303-305
+    fatal(formatv(
+        "image size ({0}) exceeds maximum allowable size ({1})",
+        FileSize, UINT32_MAX));
----------------
ruiu wrote:
> I believe you can do
> 
>  fatal("image size ("+ Twine(FileSize) + ") exceeds maximum allowable size (" + Twine(UINT32_MAX) + ")");
Apologies in advance for nit picking, but why not say something more human readable like "4GB"?


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D42010