[PATCH] D41988: [ThinLTO] - Set WeakAnyLinkage for all LinkerRedefined symbols.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 16 07:54:39 PST 2018


>>Part 1 sounds right. For part 2 I don't think that internalizing is
>>correct, we want to drop the symbol completely.
>>
>>Thanks a lot for the description, it was a bit hard to get the big
>>picture by reading the code.
>>
>>From the description I was able to create a testcase that shows why
>>internalizing symbols is not sufficient, we have to drop them:
>>
>>https://bugs.llvm.org/show_bug.cgi?id=35938
>>
>
>Thanks ! Reproduced issue with testcase provided and
>going to start debugging of it tomorrow (if nobody will take and/or fix it earlier).
>
>George.

Prepared fix for PR35938: https://reviews.llvm.org/D42107.

As far I understand we want to drop all non-prevailing symbols and not only weak ones,
this patch uses existent code that drops weak symbols currently, if it is OK, I am going
to implement the rest in a following patch(es).

George.


More information about the llvm-commits mailing list