[PATCH] ldd::COFF: initalize ErrorHandler with CanExitEarly value

[Hans Wennborg via llvm-commits]

Ah, I saw it now. Merged in r322563. Thanks!

(For reference, the Phab review is https://reviews.llvm.org/D41803)

On Tue, Jan 16, 2018 at 4:16 PM, Andrew Kelley <superjoe30 at gmail.com> wrote:
> Hans,
>
> I resubmitted this as a Phabricator patch, and Rui gave it approval for 6.0.
>
> Regards,
> Andrew
>
>
> On Tue, Jan 16, 2018 at 9:54 AM, Hans Wennborg <hans at chromium.org> wrote:
>>
>> Looks fine for 6.0 from my point of view.
>>
>> Rui, what do you think?
>>
>> On Thu, Jan 4, 2018 at 7:37 PM, Andrew Kelley <superjoe30 at gmail.com>
>> wrote:
>> >
>> >
>> > On Thu, Jan 4, 2018 at 2:37 AM, Shoaib Meenai <smeenai at fb.com> wrote:
>> >>
>> >> +Rui and Hans, in case they miss it on the list.
>> >>
>> >>
>> >>
>> >> (Side note: it's much easier to keep track of patches on Phabricator
>> >> IMO.)
>> >
>> >
>> > Thank you Shoaib, I will try that next time.
>> >
>> >>
>> >>
>> >>
>> >> From: llvm-commits <llvm-commits-bounces at lists.llvm.org> on behalf of
>> >> Andrew Kelley via llvm-commits <llvm-commits at lists.llvm.org>
>> >> Reply-To: Andrew Kelley <superjoe30 at gmail.com>
>> >> Date: Wednesday, January 3, 2018 at 10:51 PM
>> >> To: llvm-commits <llvm-commits at lists.llvm.org>
>> >> Subject: Re: [PATCH] ldd::COFF: initalize ErrorHandler with
>> >> CanExitEarly
>> >> value
>> >>
>> >>
>> >>
>> >> I would also like to request that this is backported to the release_60
>> >> branch.
>> >>
>> >>
>> >>
>> >> On Tue, Jan 2, 2018 at 11:48 PM, Andrew Kelley <superjoe30 at gmail.com>
>> >> wrote:
>> >>
>> >> Previously, the COFF driver would call exit(1) from the
>> >> ErrorHandler in the case of a link error, even if
>> >>
>> >> CanExitEarly=false was specified. Now it initializes
>> >>
>> >> the ErrorHandler in the same way that the ELF driver does.
>> >>
>> >>
>> >> diff --git a/lld/COFF/Driver.cpp b/lld/COFF/Driver.cpp
>> >> index 0e7db7b6ae3..df1ce324055 100644
>> >> --- a/lld/COFF/Driver.cpp
>> >> +++ b/lld/COFF/Driver.cpp
>> >> @@ -57,6 +57,7 @@ bool link(ArrayRef<const char *> Args, bool
>> >> CanExitEarly, raw_ostream &Diag) {
>> >>    errorHandler().ErrorLimitExceededMsg =
>> >>        "too many errors emitted, stopping now"
>> >>        " (use /ERRORLIMIT:0 to see all errors)";
>> >> +  errorHandler().ExitEarly = CanExitEarly;
>> >>    Config = make<Configuration>();
>> >>    Config->Argv = {Args.begin(), Args.end()};
>> >>    Config->CanExitEarly = CanExitEarly;
>> >>
>> >>
>> >
>> >
>
>