[PATCH] D42025: Implement --just-symbols.

[Rafael Avila de Espindola via Phabricator via llvm-commits]

espindola added inline comments.


================
Comment at: lld/ELF/InputFiles.cpp:1178
+      continue;
+
+    Elf_Sym_Range Syms = CHECK(Obj.symbols(&Sec), ObjName);
----------------
This should reject non ET_EXEC.


================
Comment at: lld/ELF/InputFiles.h:338
+template <class ELFT> class JustSymbolsFile : public ELFFileBase<ELFT> {
+  typedef typename ELFT::Shdr Elf_Shdr;
+  typedef typename ELFT::Sym Elf_Sym;
----------------
These typedefs are not used here. Please move to where they are needed.


https://reviews.llvm.org/D42025