[PATCH] D42095: [WebAssembly] Symbol changes #3: Cosmetic table, LLVM. NFC.

[Nicholas Wilson via Phabricator via llvm-commits]

ncw added inline comments.


================
Comment at: test/MC/WebAssembly/external-func-address.ll:32
 ; CHECK-NEXT:           Opcode:          I32_CONST
-; CHECK-NEXT:           Value:           0
+; CHECK-NEXT:           Value:           1
 ; CHECK-NEXT:         Functions:       [ 0 ]
----------------
Test expectations updated: all ELEM sections are now written out with offset 1. Avoids unnecessary differences between the different Wasm files.


================
Comment at: test/MC/WebAssembly/global-ctor-dtor.ll:124
 ; CHECK-NEXT:         Locals:          
-; CHECK-NEXT:         Body:            024041808080800041004180808080001081808080000D000F0B00000B
+; CHECK-NEXT:         Body:            024041818080800041004180808080001081808080000D000F0B00000B
 ; CHECK-NEXT:       - Index:           7
----------------
Test expectations updated: all "preliminary" values for relocations are incremented by one (since the table now has offset 1).


================
Comment at: test/MC/WebAssembly/weak-alias.ll:65
 ; CHECK-NEXT:           Limits:
-; CHECK-NEXT:             Initial:         0x00000002
+; CHECK-NEXT:             Initial:         0x00000001
 ; CHECK-NEXT:       - Module:          env
----------------
Test expectations now updated: in the alias test, the table is now one element smaller (here and line 134) since WasmObjectWriter now uses ResolveSymbol for the "provisional" ELEMS section - this matches the LLD behaviour, writing out the index of the actual function called rather than the import that's used as a stand-in for aliases.


Repository:
  rL LLVM

https://reviews.llvm.org/D42095