[PATCH] D42087: [DSE] Improve handling of noop stores exposed after dead interfering stores are removed

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 15 18:30:37 PST 2018


efriedma added a comment.

Do you have any size/performance numbers for this?  (Just trying to get a rough sense of how helpful this is.)



================
Comment at: lib/Transforms/Scalar/DeadStoreElimination.cpp:1082
+        MadeChange = true;
+    });
 
----------------
Can you reorganize this somehow so you don't use make_scope_exit()?  Using RAII for control flow is tricky to follow.  (If can't come up with anything better, even explicitly calling the lambda would be an improvement.)


Repository:
  rL LLVM

https://reviews.llvm.org/D42087





More information about the llvm-commits mailing list