[llvm] r322490 - [WebAssembly] Make WasmObjectWriter's destructor public; NFC
Dan Gohman via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 15 09:06:23 PST 2018
Author: djg
Date: Mon Jan 15 09:06:23 2018
New Revision: 322490
URL: http://llvm.org/viewvc/llvm-project?rev=322490&view=rev
Log:
[WebAssembly] Make WasmObjectWriter's destructor public; NFC
This fixes the FIXME introduced in r315327.
Modified:
llvm/trunk/lib/MC/WasmObjectWriter.cpp
Modified: llvm/trunk/lib/MC/WasmObjectWriter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/WasmObjectWriter.cpp?rev=322490&r1=322489&r2=322490&view=diff
==============================================================================
--- llvm/trunk/lib/MC/WasmObjectWriter.cpp (original)
+++ llvm/trunk/lib/MC/WasmObjectWriter.cpp Mon Jan 15 09:06:23 2018
@@ -239,9 +239,9 @@ public:
: MCObjectWriter(OS, /*IsLittleEndian=*/true),
TargetObjectWriter(std::move(MOTW)) {}
-private:
~WasmObjectWriter() override;
+private:
void reset() override {
CodeRelocations.clear();
DataRelocations.clear();
@@ -1423,8 +1423,5 @@ void WasmObjectWriter::writeObject(MCAss
std::unique_ptr<MCObjectWriter>
llvm::createWasmObjectWriter(std::unique_ptr<MCWasmObjectTargetWriter> MOTW,
raw_pwrite_stream &OS) {
- // FIXME: Can't use make_unique<WasmObjectWriter>(...) as WasmObjectWriter's
- // destructor is private. Is that necessary?
- return std::unique_ptr<MCObjectWriter>(
- new WasmObjectWriter(std::move(MOTW), OS));
+ return llvm::make_unique<WasmObjectWriter>(std::move(MOTW), OS);
}
More information about the llvm-commits
mailing list