[PATCH] D41723: Introduce the "retpoline" x86 mitigation technique for variant #2 of the speculative execution vulnerabilities disclosed today, specifically identified by CVE-2017-5715, "Branch Target Injection", and is one of the two halves to Spectre..

[Chandler Carruth via Phabricator via llvm-commits]

chandlerc added a comment.

Ok, I think this is all done. Rafael, I think I've implemented your suggestion as well and it still passes all my tests (including the test-suite) and a bunch of internal code I have.

Any last comments?



================
Comment at: llvm/lib/Target/X86/X86RetpolineThunks.cpp:82-83
+
+  if (skipModule(M))
+    return false;
+
----------------
MatzeB wrote:
> We need this pass for "correctness" and should never skip it I think.
Agreed and done.


Repository:
  rL LLVM

https://reviews.llvm.org/D41723