[PATCH] D41762: [DWARF] Incorrect prologue end line record.

Carlos Alberto Enciso via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 15 01:50:47 PST 2018


CarlosAlbertoEnciso added a comment.

Due to the uploaded patch, the following test case fails:

  llvm/test/DebugInfo/COFF/types-array.ll

Before the patch:

  # %bb.0:                                # %entry
  	pushl	%ebp
  	.cv_fpo_pushreg	%ebp
  	movl	%esp, %ebp
  	.cv_fpo_setframe	%ebp
  Ltmp0:
  	subl	$20, %esp
  	.cv_loc	0 1 3 7                 # t.cpp:3:7
  	movl	"?a@?1??f@@YAXXZ at 3PAHA"+16, %eax

After the patch:

  # %bb.0:                                # %entry
  	pushl	%ebp
  	.cv_fpo_pushreg	%ebp
  	movl	%esp, %ebp
  	.cv_fpo_setframe	%ebp
  	subl	$20, %esp
  Ltmp0:
  	.cv_loc	0 1 3 7                 # t.cpp:3:7
  	movl	"?a@?1??f@@YAXXZ at 3PAHA"+16, %eax

The reason for the failure is because now the frame setup code is correct. The instruction

  subl	$20, %esp

now is part of the prologue. Before the patch it was the first instruction of the function body.

The new patch will include the modified test case.


Repository:
  rL LLVM

https://reviews.llvm.org/D41762





More information about the llvm-commits mailing list