[PATCH] D40900: [Sanitizers, test] Fix sanitizer tests on Solaris (PR 33274)

[Rainer Orth via Phabricator via llvm-commits]

ro added a comment.

Thanks.  Could you please commit this for me?



================
Comment at: test/asan/TestCases/alloca_loop_unpoisoning.cc:17
+#elif defined(__FreeBSD__) || defined(__NetBSD__)
+#include <stdlib.h>
+#else
----------------
alekseyshl wrote:
> ro wrote:
> > krytarowski wrote:
> > > <stdlib.h> is included above.
> > Missed that, thanks.  We can either change the section to
> > 
> >  #elif defined(__FreeBSD__) || defined(__NetBSD__)
> > -#include <stdlib.h>
> > +// alloca is declared in <stdlib.h>.
> >  #else
> >  #include <alloca.h>
> > 
> > since the BSDs lack <alloca.h> or add a specific guard
> > for alloca.h inclusion.
> > 
> > My general point about moving such code to a common
> > test header to avoid duplication in several places still stands.
> The common test headers make sense, but as a separate refactoring patch.
Certainly.  I'll have a look once I have a chance.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D40900