[PATCH] D40845: [WebAssembly] COMDAT: LLD support

[Nicholas Wilson via Phabricator via llvm-commits]

ncw added a comment.

Thank you for reviewing and landing! And also for the "setComdat/isComdat" fix in the Clang WasmObjectWriter, I missed a trick there.

I'm glad the community's able to accept patches so easily.



================
Comment at: wasm/InputChunks.h:37
 public:
+  virtual const uint8_t *getData() const = 0;
   virtual uint32_t getSize() const = 0;
----------------
sbc100 wrote:
> no need to move this I think?
Oh, I just did it while I was at it...

I really don't like it when method don't match up! I like them to be in the same order in parent and child classes, and I like them to be in the same order in the header and code files, so I can navigate quickly. Just a habit.

It's public in both derived classes, and implemented right next to getSize(), so I felt it belongs here.

I don't mind.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D40845