[PATCH] D41613: [ELF] - Do not use HeaderSize for conditions in PltSection.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 12 14:31:43 PST 2018


ruiu added inline comments.


================
Comment at: ELF/SyntheticSections.cpp:1875
     Target->writePltHeader(Buf);
-  size_t Off = HeaderSize;
   // The IPlt is immediately after the Plt, account for this in RelOff
----------------
ruiu wrote:
> OK this change isn't pretty. Pleasse keep HeaderSize and remove getHeaderSize.
Sorry for not being clear, but I didn't mean you should revert all these changes. I'll make a change to redo what your change originally contained.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D41613





More information about the llvm-commits mailing list