[PATCH] D41893: [WebAssembly] Create synthetic __wasm_call_ctors function
Sam Clegg via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 12 14:28:53 PST 2018
sbc100 added inline comments.
================
Comment at: wasm/InputChunks.h:142-144
+ const uint8_t *getData() const override {
+ return reinterpret_cast<const uint8_t *>(Body.data());
+ }
----------------
ruiu wrote:
> This comment is not specific to this patch, but why does this function returns 'const uint8_t *' instead of `ArrayRef<uint8_t>`? Usually the latter type is better because it does bound-checking.
Good point. I'll see if I can good up a patch.
Repository:
rLLD LLVM Linker
https://reviews.llvm.org/D41893
More information about the llvm-commits
mailing list