[llvm] r322411 - [InstSimplify] add tests for implied ptr cmp with null (PR35790); NFC

Sanjay Patel via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 12 14:16:27 PST 2018


Author: spatel
Date: Fri Jan 12 14:16:26 2018
New Revision: 322411

URL: http://llvm.org/viewvc/llvm-project?rev=322411&view=rev
Log:
[InstSimplify] add tests for implied ptr cmp with null (PR35790); NFC

Modified:
    llvm/trunk/test/Transforms/InstSimplify/and-or-icmp-zero.ll

Modified: llvm/trunk/test/Transforms/InstSimplify/and-or-icmp-zero.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/InstSimplify/and-or-icmp-zero.ll?rev=322411&r1=322410&r2=322411&view=diff
==============================================================================
--- llvm/trunk/test/Transforms/InstSimplify/and-or-icmp-zero.ll (original)
+++ llvm/trunk/test/Transforms/InstSimplify/and-or-icmp-zero.ll Fri Jan 12 14:16:26 2018
@@ -1,7 +1,8 @@
 ; RUN: opt < %s -instsimplify -S | FileCheck %s
 
-; In the next 8 tests (4 commutes * 2 (and/or)), eliminate the simple (not) null
-; check because that compare is implied by the masked compare of the same operand.
+; In the next 16 tests (4 commutes * 2 (and/or) * 2 optional ptrtoint casts),
+; eliminate the simple (not) null check because that compare is implied by the
+; masked compare of the same operand.
 ; Vary types between scalar and vector and weird for extra coverage.
 
 ; or (icmp eq (and X, ?), 0), (icmp eq X, 0) --> icmp eq (and X, ?), 0
@@ -121,6 +122,158 @@ define i1 @and_cmps_eq_zero_with_mask_co
   %somebits = and i64 %y, %x
   %somebits_are_not_zero = icmp ne i64 %somebits, 0
   %r = and i1 %isnotnull, %somebits_are_not_zero
+  ret i1 %r
+}
+
+; or (icmp eq (and (ptrtoint P), ?), 0), (icmp eq P, 0) --> icmp eq (and (ptrtoint P), ?), 0
+
+define i1 @or_cmps_ptr_eq_zero_with_mask_commute1(i64* %p, i64 %y) {
+; CHECK-LABEL: @or_cmps_ptr_eq_zero_with_mask_commute1(
+; CHECK-NEXT:    [[ISNULL:%.*]] = icmp eq i64* %p, null
+; CHECK-NEXT:    [[X:%.*]] = ptrtoint i64* %p to i64
+; CHECK-NEXT:    [[SOMEBITS:%.*]] = and i64 [[X]], %y
+; CHECK-NEXT:    [[SOMEBITS_ARE_ZERO:%.*]] = icmp eq i64 [[SOMEBITS]], 0
+; CHECK-NEXT:    [[R:%.*]] = or i1 [[SOMEBITS_ARE_ZERO]], [[ISNULL]]
+; CHECK-NEXT:    ret i1 [[R]]
+;
+  %isnull = icmp eq i64* %p, null
+  %x = ptrtoint i64* %p to i64
+  %somebits = and i64 %x, %y
+  %somebits_are_zero = icmp eq i64 %somebits, 0
+  %r = or i1 %somebits_are_zero, %isnull
+  ret i1 %r
+}
+
+; or (icmp eq P, 0), (icmp eq (and (ptrtoint P), ?), 0) --> icmp eq (and (ptrtoint P), ?), 0
+
+define <2 x i1> @or_cmps_ptr_eq_zero_with_mask_commute2(<2 x i64*> %p, <2 x i64> %y) {
+; CHECK-LABEL: @or_cmps_ptr_eq_zero_with_mask_commute2(
+; CHECK-NEXT:    [[ISNULL:%.*]] = icmp eq <2 x i64*> %p, zeroinitializer
+; CHECK-NEXT:    [[X:%.*]] = ptrtoint <2 x i64*> %p to <2 x i64>
+; CHECK-NEXT:    [[SOMEBITS:%.*]] = and <2 x i64> [[X]], %y
+; CHECK-NEXT:    [[SOMEBITS_ARE_ZERO:%.*]] = icmp eq <2 x i64> [[SOMEBITS]], zeroinitializer
+; CHECK-NEXT:    [[R:%.*]] = or <2 x i1> [[ISNULL]], [[SOMEBITS_ARE_ZERO]]
+; CHECK-NEXT:    ret <2 x i1> [[R]]
+;
+  %isnull = icmp eq <2 x i64*> %p, zeroinitializer
+  %x = ptrtoint <2 x i64*> %p to <2 x i64>
+  %somebits = and <2 x i64> %x, %y
+  %somebits_are_zero = icmp eq <2 x i64> %somebits, zeroinitializer
+  %r = or <2 x i1> %isnull, %somebits_are_zero
+  ret <2 x i1> %r
+}
+
+; or (icmp eq (and ?, (ptrtoint P)), 0), (icmp eq P, 0) --> icmp eq (and ?, (ptrtoint P)), 0
+
+define i1 @or_cmps_ptr_eq_zero_with_mask_commute3(i4* %p, i4 %y) {
+; CHECK-LABEL: @or_cmps_ptr_eq_zero_with_mask_commute3(
+; CHECK-NEXT:    [[ISNULL:%.*]] = icmp eq i4* %p, null
+; CHECK-NEXT:    [[X:%.*]] = ptrtoint i4* %p to i4
+; CHECK-NEXT:    [[SOMEBITS:%.*]] = and i4 %y, [[X]]
+; CHECK-NEXT:    [[SOMEBITS_ARE_ZERO:%.*]] = icmp eq i4 [[SOMEBITS]], 0
+; CHECK-NEXT:    [[R:%.*]] = or i1 [[SOMEBITS_ARE_ZERO]], [[ISNULL]]
+; CHECK-NEXT:    ret i1 [[R]]
+;
+  %isnull = icmp eq i4* %p, null
+  %x = ptrtoint i4* %p to i4
+  %somebits = and i4 %y, %x
+  %somebits_are_zero = icmp eq i4 %somebits, 0
+  %r = or i1 %somebits_are_zero, %isnull
+  ret i1 %r
+}
+
+; or (icmp eq P, 0), (icmp eq (and ?, (ptrtoint P)), 0) --> icmp eq (and ?, (ptrtoint P)), 0
+
+define <2 x i1> @or_cmps_ptr_eq_zero_with_mask_commute4(<2 x i4*> %p, <2 x i4> %y) {
+; CHECK-LABEL: @or_cmps_ptr_eq_zero_with_mask_commute4(
+; CHECK-NEXT:    [[ISNULL:%.*]] = icmp eq <2 x i4*> %p, zeroinitializer
+; CHECK-NEXT:    [[X:%.*]] = ptrtoint <2 x i4*> %p to <2 x i4>
+; CHECK-NEXT:    [[SOMEBITS:%.*]] = and <2 x i4> %y, [[X]]
+; CHECK-NEXT:    [[SOMEBITS_ARE_ZERO:%.*]] = icmp eq <2 x i4> [[SOMEBITS]], zeroinitializer
+; CHECK-NEXT:    [[R:%.*]] = or <2 x i1> [[ISNULL]], [[SOMEBITS_ARE_ZERO]]
+; CHECK-NEXT:    ret <2 x i1> [[R]]
+;
+  %isnull = icmp eq <2 x i4*> %p, zeroinitializer
+  %x = ptrtoint <2 x i4*> %p to <2 x i4>
+  %somebits = and <2 x i4> %y, %x
+  %somebits_are_zero = icmp eq <2 x i4> %somebits, zeroinitializer
+  %r = or <2 x i1> %isnull, %somebits_are_zero
+  ret <2 x i1> %r
+}
+
+; and (icmp ne (and (ptrtoint P), ?), 0), (icmp ne P, 0) --> icmp ne (and (ptrtoint P), ?), 0
+
+define <3 x i1> @and_cmps_ptr_eq_zero_with_mask_commute1(<3 x i4*> %p, <3 x i4> %y) {
+; CHECK-LABEL: @and_cmps_ptr_eq_zero_with_mask_commute1(
+; CHECK-NEXT:    [[ISNOTNULL:%.*]] = icmp ne <3 x i4*> %p, zeroinitializer
+; CHECK-NEXT:    [[X:%.*]] = ptrtoint <3 x i4*> %p to <3 x i4>
+; CHECK-NEXT:    [[SOMEBITS:%.*]] = and <3 x i4> [[X]], %y
+; CHECK-NEXT:    [[SOMEBITS_ARE_NOT_ZERO:%.*]] = icmp ne <3 x i4> [[SOMEBITS]], zeroinitializer
+; CHECK-NEXT:    [[R:%.*]] = and <3 x i1> [[SOMEBITS_ARE_NOT_ZERO]], [[ISNOTNULL]]
+; CHECK-NEXT:    ret <3 x i1> [[R]]
+;
+  %isnotnull = icmp ne <3 x i4*> %p, zeroinitializer
+  %x = ptrtoint <3 x i4*> %p to <3 x i4>
+  %somebits = and <3 x i4> %x, %y
+  %somebits_are_not_zero = icmp ne <3 x i4> %somebits, zeroinitializer
+  %r = and <3 x i1> %somebits_are_not_zero, %isnotnull
+  ret <3 x i1> %r
+}
+
+; and (icmp ne P, 0), (icmp ne (and (ptrtoint P), ?), 0) --> icmp ne (and (ptrtoint P), ?), 0
+
+define i1 @and_cmps_ptr_eq_zero_with_mask_commute2(i4* %p, i4 %y) {
+; CHECK-LABEL: @and_cmps_ptr_eq_zero_with_mask_commute2(
+; CHECK-NEXT:    [[ISNOTNULL:%.*]] = icmp ne i4* %p, null
+; CHECK-NEXT:    [[X:%.*]] = ptrtoint i4* %p to i4
+; CHECK-NEXT:    [[SOMEBITS:%.*]] = and i4 [[X]], %y
+; CHECK-NEXT:    [[SOMEBITS_ARE_NOT_ZERO:%.*]] = icmp ne i4 [[SOMEBITS]], 0
+; CHECK-NEXT:    [[R:%.*]] = and i1 [[ISNOTNULL]], [[SOMEBITS_ARE_NOT_ZERO]]
+; CHECK-NEXT:    ret i1 [[R]]
+;
+  %isnotnull = icmp ne i4* %p, null
+  %x = ptrtoint i4* %p to i4
+  %somebits = and i4 %x, %y
+  %somebits_are_not_zero = icmp ne i4 %somebits, 0
+  %r = and i1 %isnotnull, %somebits_are_not_zero
+  ret i1 %r
+}
+
+; and (icmp ne (and ?, (ptrtoint P)), 0), (icmp ne P, 0) --> icmp ne (and ?, (ptrtoint P)), 0
+
+define <3 x i1> @and_cmps_ptr_eq_zero_with_mask_commute3(<3 x i64*> %p, <3 x i64> %y) {
+; CHECK-LABEL: @and_cmps_ptr_eq_zero_with_mask_commute3(
+; CHECK-NEXT:    [[ISNOTNULL:%.*]] = icmp ne <3 x i64*> %p, zeroinitializer
+; CHECK-NEXT:    [[X:%.*]] = ptrtoint <3 x i64*> %p to <3 x i64>
+; CHECK-NEXT:    [[SOMEBITS:%.*]] = and <3 x i64> %y, [[X]]
+; CHECK-NEXT:    [[SOMEBITS_ARE_NOT_ZERO:%.*]] = icmp ne <3 x i64> [[SOMEBITS]], zeroinitializer
+; CHECK-NEXT:    [[R:%.*]] = and <3 x i1> [[SOMEBITS_ARE_NOT_ZERO]], [[ISNOTNULL]]
+; CHECK-NEXT:    ret <3 x i1> [[R]]
+;
+  %isnotnull = icmp ne <3 x i64*> %p, zeroinitializer
+  %x = ptrtoint <3 x i64*> %p to <3 x i64>
+  %somebits = and <3 x i64> %y, %x
+  %somebits_are_not_zero = icmp ne <3 x i64> %somebits, zeroinitializer
+  %r = and <3 x i1> %somebits_are_not_zero, %isnotnull
+  ret <3 x i1> %r
+}
+
+; and (icmp ne P, 0), (icmp ne (and ?, (ptrtoint P)), 0) --> icmp ne (and ?, (ptrtoint P)), 0
+
+define i1 @and_cmps_ptr_eq_zero_with_mask_commute4(i64* %p, i64 %y) {
+; CHECK-LABEL: @and_cmps_ptr_eq_zero_with_mask_commute4(
+; CHECK-NEXT:    [[ISNOTNULL:%.*]] = icmp ne i64* %p, null
+; CHECK-NEXT:    [[X:%.*]] = ptrtoint i64* %p to i64
+; CHECK-NEXT:    [[SOMEBITS:%.*]] = and i64 %y, [[X]]
+; CHECK-NEXT:    [[SOMEBITS_ARE_NOT_ZERO:%.*]] = icmp ne i64 [[SOMEBITS]], 0
+; CHECK-NEXT:    [[R:%.*]] = and i1 [[ISNOTNULL]], [[SOMEBITS_ARE_NOT_ZERO]]
+; CHECK-NEXT:    ret i1 [[R]]
+;
+  %isnotnull = icmp ne i64* %p, null
+  %x = ptrtoint i64* %p to i64
+  %somebits = and i64 %y, %x
+  %somebits_are_not_zero = icmp ne i64 %somebits, 0
+  %r = and i1 %isnotnull, %somebits_are_not_zero
   ret i1 %r
 }
 




More information about the llvm-commits mailing list