[PATCH] D42003: [WebAssembly] Add --export flag to force a symbol to be exported

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 12 13:55:41 PST 2018


sbc100 added inline comments.


================
Comment at: wasm/Driver.cpp:333
 
+  for (StringRef S : args::getStrings(Args, OPT_export)) {
+    Symbol *Sym = Symtab->find(S);
----------------
ruiu wrote:
> This is more common way of doing the same thing:
> 
>   for (auto *Arg : Args.filter(OPT_export)) {
>     // use Arg->getValue() instead of S
>   }
Ok, fixed here and elsewhere in this file.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D42003





More information about the llvm-commits mailing list