[PATCH] D40845: [WebAssembly] COMDAT: LLD support

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added a comment.

Looks like we need one more rebase then this is good to go.



================
Comment at: wasm/InputChunks.h:37
 public:
+  virtual const uint8_t *getData() const = 0;
   virtual uint32_t getSize() const = 0;
----------------
no need to move this I think?


================
Comment at: wasm/InputFiles.cpp:173
 
+bool ObjFile::isExcludedByComdat(InputChunk *Chunk) const {
+  StringRef Comdat = Chunk->getComdat();
----------------
I guess this could be a local lambda function since its just used in one function?


================
Comment at: wasm/Writer.cpp:443
+      Comdats[Comdat].emplace_back(
+          ComdatEntry{WASM_COMDAT_FUNCTION, I + NumFunctionImports});
+  }
----------------
I think you can just use F->getOutputIndex() here and avoid `NumFunctionImports` and use a foreach loop instread


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D40845