[PATCH] D41978: Allow unaligned access to ELF file data structures.

[Rui Ueyama via llvm-commits]

Actually this is the last occurrence of packed_endian_specific_integral in
this file after I commit https://reviews.llvm.org/D41973. That's why I
made D41973
in the first place.

On Fri, Jan 12, 2018 at 8:18 AM, Rafael Avila de Espindola <
rafael.espindola at gmail.com> wrote:

> Rui Ueyama via Phabricator <reviews at reviews.llvm.org> writes:
>
> > Index: llvm/include/llvm/Object/ELFTypes.h
> > ===================================================================
> > --- llvm/include/llvm/Object/ELFTypes.h
> > +++ llvm/include/llvm/Object/ELFTypes.h
> > @@ -44,7 +44,7 @@
> >  template <endianness E, bool Is64> struct ELFType {
> >  private:
> >    template <typename Ty>
> > -  using packed = support::detail::packed_endian_specific_integral<Ty,
> E, 2>;
> > +  using packed = support::detail::packed_endian_specific_integral<Ty,
> E, 1>;
> >
> >  public:
> >    static const endianness TargetEndianness = E;
> >
> >
>
> There are more uses of packed_endian_specific_integral in that
> file. Probably the best way to fix this is to introduce a template
> unaligned<T,E> = packed_endian_specific_integral<T, E, 1> and replace
> all direct uses of packed_endian_specific_integral in that file.
>
> Cheers,
> Rafael
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180112/e154ea36/attachment.html>