[PATCH] D41297: [ThinLTO] Implement summary visualizer

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 12 09:57:34 PST 2018


tejohnson added a comment.

In https://reviews.llvm.org/D41297#974793, @evgeny777 wrote:

> @tejohnson The `BM.parseModule` is invoked in the very end of thin link (see `runThinLTOBackendThread`). How can it work if it's not guaranteed that we have valid BC data till this moment? Note: parse module uses `Stream`


Good point. Since we create this map during combined index creation, and use it through the backends, then I guess we do have this available. Mehdi - any concerns I have missed?

We won't be able to dump the graph with names on an existing combined index, but that is much less important to support.


https://reviews.llvm.org/D41297





More information about the llvm-commits mailing list