[PATCH] D41969: [AMDGPU] stop image_store being moved illegally

[Tom Stellard via Phabricator via llvm-commits]

tstellar added a comment.

In https://reviews.llvm.org/D41969#974642, @arsenm wrote:

> In https://reviews.llvm.org/D41969#974088, @tstellar wrote:
>
> > In https://reviews.llvm.org/D41969#974049, @tstellar wrote:
> >
> > > I think changing AMDGPUImagePseudoSourceValue::isAliased() to return true may fix this.
> >
> >
> > This is the most conservative way to fix it.  I think the better way to fix this would be to change AMDGPUImagePseudoSourceValue::mayAlias() to true.  You could improve this even further by making sure that image instructions that reference the same resource have the same PseudoSourceValue.   ScheduleDAGInstrs::buildSchedGraph() is where all the dependencies are calculated.
>
>
> That images have the same resource argument do have the same PSV now. I think the issue may be the non-constant offsets in the intrinsics aren't represented anywhere


Ok, it looks like maybe just setting the MachineMemOperand size to something non-zero may work for now.


https://reviews.llvm.org/D41969