[PATCH] D41988: [ThinLTO] - Set WeakAnyLinkage for all LinkerRedefined symbols.

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 12 07:53:06 PST 2018


tejohnson added a comment.

The same handling occurs for regular LTO (setting LinkerRedefined to WeakAny only when prevailing). Is this a problem there? If not, why? Answering my own question perhaps, but I guess this is because in the ThinLTO case we end up importing bar2 and therefore promoting it to external linkage instead of leaving it alone which would cause it to be internalized?

It seems like the bug then is that we import a non-prevailing value. Although the best fix for that in general seems to be what this patch is doing - marking as WeakAnyLinkage.


https://reviews.llvm.org/D41988





More information about the llvm-commits mailing list