[PATCH] D41956: [docs] Tweak update to Phabricator docs about setting repository for diffs uploaded via web
Ben Hamilton via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 12 07:38:06 PST 2018
benhamilton updated this revision to Diff 129626.
benhamilton added a comment.
- Leave first Repository field blank.
https://reviews.llvm.org/D41956
Files:
docs/Phabricator.rst
Index: docs/Phabricator.rst
===================================================================
--- docs/Phabricator.rst
+++ docs/Phabricator.rst
@@ -65,15 +65,16 @@
* Click *Differential*.
* Click *+ Create Diff*.
* Paste the text diff or browse to the patch file. Click *Create Diff*.
-* In the Repository field, enter the name of the project (LLVM, Clang,
- etc.) to which the review should be sent.
+* Leave this first Repository field blank. (We'll fill in the Repository
+ later, when sending the review.)
* Leave the drop down on *Create a new Revision...* and click *Continue*.
* Enter a descriptive title and summary. The title and summary are usually
in the form of a :ref:`commit message <commit messages>`.
* Add reviewers (see below for advice). (If you set the Repository field
correctly, llvm-commits or cfe-commits will be subscribed automatically;
otherwise, you will have to manually subscribe them.)
-* Leave the Repository and Project fields blank.
+* In the Repository field, enter the name of the project (LLVM, Clang,
+ etc.) to which the review should be sent.
* Click *Save*.
To submit an updated patch:
@@ -83,7 +84,8 @@
* Paste the updated diff or browse to the updated patch file. Click *Create Diff*.
* Select the review you want to from the *Attach To* dropdown and click
*Continue*.
-* Leave the Repository and Project fields blank.
+* In the Repository field, enter the name of the project (LLVM, Clang,
+ etc.) to which the review should be sent.
* Add comments about the changes in the new diff. Click *Save*.
Choosing reviewers: You typically pick one or two people as initial reviewers.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D41956.129626.patch
Type: text/x-patch
Size: 1656 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180112/1b60463d/attachment.bin>
More information about the llvm-commits
mailing list