[PATCH] D41578: [SCEV] Do not cache S -> V if S is not equivalent of V
Sanjoy Das via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 11 22:25:46 PST 2018
sanjoy added a comment.
In https://reviews.llvm.org/D41578#974249, @skatkov wrote:
> Hi Sanjoy, I guess this piece of code is common one and will be executed SCEV is created each time whenever it is a LSR or earlier passes. Do you propose to introduce some flag and use it in LSR?
> This seems to me very intrusive fix.
There is already a `SCEVExpander::LSRMode`.
> I think the better fix would be really to understand why SCEV looses these flags and fix/extend that place and as I understand Evgeny looks in this direction.
Agreed.
Repository:
rL LLVM
https://reviews.llvm.org/D41578
More information about the llvm-commits
mailing list