[PATCH] D41926: [DWARFv5] CodeGen support for MD5 checksum

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 11 17:13:15 PST 2018


aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

One more nitpick, otherwise LGTM!



================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp:103
   // extend .file to support this.
+  unsigned CUID = Asm->OutStreamer->hasRawTextSupport() ? 0 : getUniqueID();
+  if (!File)
----------------
Should this be an Optional<unsigned> parameter instead of using 0?


https://reviews.llvm.org/D41926





More information about the llvm-commits mailing list