[PATCH] D41969: [AMDGPU] stop image_store being moved illegally

Tom Stellard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 11 16:14:03 PST 2018


tstellar added a comment.

In https://reviews.llvm.org/D41969#974049, @tstellar wrote:

> I think changing AMDGPUImagePseudoSourceValue::isAliased() to return true may fix this.


This is the most conservative way to fix it.  I think the better way to fix this would be to change AMDGPUImagePseudoSourceValue::mayAlias() to true.  You could improve this even further by making sure that image instructions that reference the same resource have the same PseudoSourceValue.   ScheduleDAGInstrs::buildSchedGraph() is where all the dependencies are calculated.


https://reviews.llvm.org/D41969





More information about the llvm-commits mailing list