[PATCH] D41602: [hwasan] Stack instrumentation.

[Evgenii Stepanov via Phabricator via llvm-commits]

eugenis added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:355
+    //   IRB.CreateStore(JustTag, IRB.CreateConstGEP1_32(ShadowPtr, i));
+    IRB.CreateMemSet(ShadowPtr, JustTag, ShadowSize, /*Align=*/1);
+  }
----------------
kcc wrote:
> kcc wrote:
> > Will this work if 
> >   * the size is large and memset doesn't get inlined
> >   * hwasan has the msan interceptor
> > ? 
> I mean, 
> * hwasan has the memset interceptor
That's why I'm changing the memset interceptor to skips checks if the address is in the shadow range.


https://reviews.llvm.org/D41602