[PATCH] D41922: [WebAssembly] When loading libraries look for companion `.imports` file

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 11 14:15:15 PST 2018


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: wasm/Driver.cpp:165
+// Currently we allow a ".imports" to live alongside a library. This can
+// be used to specify a list of symbols which are can be undefined at link
+// time (imported from the environment).  For example libc.a include an
----------------
typo: are can


================
Comment at: wasm/Driver.cpp:167
+// time (imported from the environment).  For example libc.a include an
+// import file that list all the syscall function it relies on at runtime.
+// In the long run this information would be better stored as a symbol
----------------
that  list -> that lists
syscall function -> syscall functions


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D41922





More information about the llvm-commits mailing list