[PATCH] D38906: AMDGPU/SI: Implement d16 support for buffer intrinsics

[Changpeng Fang via Phabricator via llvm-commits]

cfang added inline comments.


================
Comment at: lib/Target/AMDGPU/SIISelLowering.cpp:4915
+    bool IsD16 = false;
+    SDValue VData = handleVDataToStore(Op, &IsD16, DAG);
     SDValue Ops[] = {
----------------
arsenm wrote:
> You don't need a pointer out argument here. You can just have handleVDataToStore return SDValue() if it doesn't need to do anything. If it actaully does something you know it is d16
I redesigned this function. It will called called only when VData is the type of "D16".

What do you think?


https://reviews.llvm.org/D38906