[PATCH] D41926: [DWARFv5] CodeGen support for MD5 checksum

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 11 09:10:55 PST 2018


aprantl added a comment.

Could you perhaps add a check that the string matches [0-9a-z]+ (with the right amount of characters) here?

  void Verifier::visitDIFile(const DIFile &N) {
    AssertDI(N.getTag() == dwarf::DW_TAG_file_type, "invalid tag", &N);
    AssertDI((N.getChecksumKind() != DIFile::CSK_None ||
              N.getChecksum().empty()), "invalid checksum kind", &N);
  }


https://reviews.llvm.org/D41926





More information about the llvm-commits mailing list