[PATCH] D41658: [RISCV] Encode RISCV specific ELF e_flags to RISCV Binary by RISCVTargetStreamer

[Alex Bradbury via Phabricator via llvm-commits]

asb added a comment.

With a couple of minor nits, looks good to me. Thanks as always Shiva



================
Comment at: lib/Target/RISCV/MCTargetDesc/RISCVTargetStreamer.h:22
+
+// This part is for ELF object output
+class RISCVTargetELFStreamer : public RISCVTargetStreamer {
----------------
Nitpick: full-stop after comment.

Does the comment add value? Maybe just delete it.


================
Comment at: test/MC/RISCV/elf-flags.s:1
+# RUN: llvm-mc -mattr=+c -filetype=obj < %s | llvm-readobj -file-headers - | FileCheck --check-prefix=ExtC %s
+
----------------
Need to set the target for llvm-mc.

Should probably have RUN lines for both riscv32 and riscv64 as many of the other test/MC/RISCV tests do.


Repository:
  rL LLVM

https://reviews.llvm.org/D41658