[PATCH] D41107: [FuzzMutate] Avoid using swifterror as a source operand
Phabricator via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 11 06:44:29 PST 2018
This revision was automatically updated to reflect the committed changes.
Closed by commit rL322280: [FuzzMutate] Avoid using swifterror as a source operand (authored by igor.laevsky, committed by ).
Repository:
rL LLVM
https://reviews.llvm.org/D41107
Files:
llvm/trunk/include/llvm/FuzzMutate/OpDescriptor.h
llvm/trunk/unittests/FuzzMutate/RandomIRBuilderTest.cpp
Index: llvm/trunk/include/llvm/FuzzMutate/OpDescriptor.h
===================================================================
--- llvm/trunk/include/llvm/FuzzMutate/OpDescriptor.h
+++ llvm/trunk/include/llvm/FuzzMutate/OpDescriptor.h
@@ -20,6 +20,7 @@
#include "llvm/ADT/SmallVector.h"
#include "llvm/IR/Constants.h"
#include "llvm/IR/DerivedTypes.h"
+#include "llvm/IR/Instructions.h"
#include "llvm/IR/Type.h"
#include "llvm/IR/Value.h"
#include <functional>
@@ -128,7 +129,7 @@
static inline SourcePred anyPtrType() {
auto Pred = [](ArrayRef<Value *>, const Value *V) {
- return V->getType()->isPointerTy();
+ return V->getType()->isPointerTy() && !V->isSwiftError();
};
auto Make = [](ArrayRef<Value *>, ArrayRef<Type *> Ts) {
std::vector<Constant *> Result;
@@ -142,6 +143,9 @@
static inline SourcePred sizedPtrType() {
auto Pred = [](ArrayRef<Value *>, const Value *V) {
+ if (V->isSwiftError())
+ return false;
+
if (const auto *PtrT = dyn_cast<PointerType>(V->getType()))
return PtrT->getElementType()->isSized();
return false;
Index: llvm/trunk/unittests/FuzzMutate/RandomIRBuilderTest.cpp
===================================================================
--- llvm/trunk/unittests/FuzzMutate/RandomIRBuilderTest.cpp
+++ llvm/trunk/unittests/FuzzMutate/RandomIRBuilderTest.cpp
@@ -266,4 +266,34 @@
}
}
+TEST(RandomIRBuilderTest, SwiftError) {
+ // Check that we never pick swifterror value as a source for operation
+ // other than load, store and call.
+
+ LLVMContext Ctx;
+ const char *SourceCode = "declare void @use(i8** swifterror %err)"
+ "define void @test() {\n"
+ "entry:\n"
+ " %err = alloca swifterror i8*, align 8\n"
+ " call void @use(i8** swifterror %err)\n"
+ " ret void\n"
+ "}";
+ auto M = parseAssembly(SourceCode, Ctx);
+
+ std::vector<Type *> Types = {Type::getInt8Ty(Ctx)};
+ RandomIRBuilder IB(Seed, Types);
+
+ // Get first basic block of the test function
+ Function &F = *M->getFunction("test");
+ BasicBlock &BB = *F.begin();
+ Instruction *Alloca = &*BB.begin();
+
+ fuzzerop::OpDescriptor Descr = fuzzerop::gepDescriptor(1);
+
+ for (int i = 0; i < 10; ++i) {
+ Value *V = IB.findOrCreateSource(BB, {Alloca}, {}, Descr.SourcePreds[0]);
+ ASSERT_FALSE(isa<AllocaInst>(V));
+ }
+}
+
}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D41107.129442.patch
Type: text/x-patch
Size: 2467 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180111/2cc0548e/attachment.bin>
More information about the llvm-commits
mailing list