[PATCH] D41126: [SelectionDAG] Fixed f16-from-vector promotion problem

Sam Parker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 11 06:31:00 PST 2018


samparker added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp:175
+      && Op.getValueType().getVectorNumElements() == 1)
+    Op = GetScalarizedVector(Op);
   EVT NewVT = N->getValueType(0).getVectorElementType();
----------------
arsenm wrote:
> Can you add an assert that the v1 type isn't legal?
Hi,
The added assert is causing issues in our AArch64 tests... why is it necessary?


Repository:
  rL LLVM

https://reviews.llvm.org/D41126





More information about the llvm-commits mailing list