[PATCH] D41293: [DAG] Improve Dependency analysis when doing multi-node Instruction Selection

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added a reviewer: RKSimon.
RKSimon added a comment.

A couple of (very) minor observations



================
Comment at: llvm/include/llvm/CodeGen/SelectionDAGNodes.h:824
+      if (TopologicalPrune && (NId > 0) && (MId > 0) &&
+          (M->getNodeId() < NId)) {
+        DeferredNodes.push_back(M);
----------------
(MId < NId)


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp:2135
 
-/// findNonImmUse - Return true if "Use" is a non-immediate use of "Def".
-/// This function iteratively traverses up the operand chain, ignoring
-/// certain nodes.
-static bool findNonImmUse(SDNode *Use, SDNode* Def, SDNode *ImmedUse,
-                          SDNode *Root, SmallPtrSetImpl<SDNode*> &Visited,
+/// findNonImmUse - Return true if "Def" is a predecessor of "root" via a path
+/// beyond "ImmedUse".  We may ignore chains as they are checked separately.
----------------
Root


https://reviews.llvm.org/D41293