[PATCH] D41613: [ELF] - Do not use HeaderSize for conditions in PltSection.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 11 02:17:18 PST 2018


grimar added inline comments.


================
Comment at: ELF/Writer.cpp:372-374
+  InX::Plt = make<PltSection>(Target->PltHeaderSize, false /*IsIplt*/);
   Add(InX::Plt);
+  InX::Iplt = make<PltSection>(0, true /*IsIplt*/);
----------------
ruiu wrote:
> Passing (PltHeaderSize, false) or (0, true) is strange. You should just pass true or false and infer the header size inside the class.
With this suggestion patch looks better IMO, thanks.


https://reviews.llvm.org/D41613





More information about the llvm-commits mailing list