[PATCH] D41700: [RISCV] Refactory the existing CC_RISCV32 function to conform to the CCAssignFn type

[Leslie Zhai via Phabricator via llvm-commits]

xiangzhai updated this revision to Diff 129404.
xiangzhai added a comment.

Hi LLVM developers,

Thanks for your code view, I can rebase my patch based on https://reviews.llvm.org/D40805 .

1. Consider about `IsFixed` and `OrigTy`, but assert as firstly:

  assert(IsFixed && "IsFixed support not yet implemented");
  assert(OrigTy && "OrigTy support not yet implemented");

The implementation of `RISCVCCState` will be in the next patch, please give me some suggestion about custom `RISCVCCState` inherited from `CCState`, I think, at least, it needs to cover `IsFixed` and `OrigTy`.

2. Remove parameter `DL` for `CC_RISCV`, because it is able to use `State.getMachineFunction().getDataLayout()` through parameter `State`.

Please review my patch again, thanks a lot!

Regards,
Leslie Zhai


Repository:
  rL LLVM

https://reviews.llvm.org/D41700

Files:
  lib/Target/RISCV/RISCVISelLowering.cpp
  lib/Target/RISCV/RISCVISelLowering.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D41700.129404.patch
Type: text/x-patch
Size: 7471 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180111/dd3e1b85/attachment-0001.bin>