[PATCH] D41403: [ELF] Fix incorrect physical address on self-referencing AT command

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 10 23:14:47 PST 2018


On Thu, Jan 11, 2018 at 3:00 AM, Rafael Avila de Espindola <
rafael.espindola at gmail.com> wrote:

> Erick Reyes <erickreyes at google.com> writes:
>
> > Just reviewed Rafael's patch and confirmed it also fixes the issue and
> > passes all tests on r322147.
> >
> > However, I can't tell if the change in switchTo() can have side effects
> > since this function is called in LinkerScript::assignAddresses().
>
> If you don't mind my preference would be to go with my patch for now since
> it
> avoids duplicating the alignment computation.
>
> Rui, what do you think?
>

I don't have a strong preference. Please go ahead if you still want.


>
> Cheers,
> Rafael
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180110/d7b429ff/attachment.html>


More information about the llvm-commits mailing list