[PATCH] D41928: [ELF] Fix SysV hash tables with --no-rosegment

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 10 22:48:31 PST 2018


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: ELF/SyntheticSections.cpp:1839-1841
+  // The output buffer is not guaranteed to be zero-cleared because we pre-
+  // fill executable sections with trap instructions. This is a precaution
+  // for that case, which happens only when -no-rosegment is given.
----------------
If you copy-n-paste this comment, update the other comment to refer this one, so that we won't end up having the identical comment in two functions.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D41928





More information about the llvm-commits mailing list