[PATCH] D41915: [lldCOFF] Print detailed timing information with /VERBOSE

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added inline comments.


================
Comment at: lld/COFF/Driver.cpp:951
       } else if (S.startswith("lldlto=")) {
+        Config->Timer.addPhase("ThinLTO", TP_ThinLTO);
         StringRef OptLevel = S.substr(7);
----------------
I gather that the intent is to add a "ThinLTO" phase to the timing output only if we end up doing LTO, but a user is not required to pass this flag in order to use LTO. Instead, we always perform LTO if the user passes at least one bitcode input file. You can find the check for that condition as well as the code that actually does LTO in the function `SymbolTable::addCombinedLTOObject()`.

Also, I'd call this "LTO" and not "ThinLTO" because the linker supports both full and thin LTO.


https://reviews.llvm.org/D41915