[PATCH] D41893: [WebAssembly] Create synthetic __wasm_call_ctors function
Sam Clegg via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 10 15:04:59 PST 2018
sbc100 added inline comments.
================
Comment at: wasm/Writer.cpp:695
+ raw_string_ostream OS(CtorFunctionBody);
+ writeUleb128(OS, 2 + (2 * InitFunctions.size()), "function size");
+ writeUleb128(OS, 0, "num locals");
----------------
AndrewScheidecker wrote:
> This size needs to account for the variable length function indices. Perhaps just wait until after the encoded function is generated to compute the size?
Good call, I was being very lazy.
Repository:
rLLD LLVM Linker
https://reviews.llvm.org/D41893
More information about the llvm-commits
mailing list