[PATCH] D41915: [lldCOFF] Print detailed timing information with /VERBOSE

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: lld/COFF/PDB.cpp:1014-1015
+
+  PdbCommitTimer.end();
+  FullPdbLinkTimer.end();
 }
----------------
ruiu wrote:
> zturner wrote:
> > ruiu wrote:
> > > These things should be done in the RAII style.
> > I didn't do RAII style here because we want to start and stop in the middle of functions sometimes.  It seemed inconvenient to have to make a nested scope just for that.
> I guess it's because the timing information is printed out along with other debug info. How about adding a new command line just for this feature?
It's worth noting that /verbose makes the linker slower because generating and emitting debug messages is sometimes not cheap. For that reason it makes sense to separate the flag.


https://reviews.llvm.org/D41915