[PATCH] D37631: [libFuzzer] Support using libc++

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added a comment.

I see a lot of these on "ninja check-fuzzer"

  ******************** TEST 'LLVMFuzzer :: value-profile-set.test' FAILED ********************
  Script:
  --
  /usr/local/google/home/vitalybuka/src/llvm.git/out/build-clang-none/./bin/clang -std=c++11 -stdlib=libc++ -lc++ -static-libstdc++ -gline-tables-only  -fsanitize=address,fuzzer -I/usr/local/google/home/vitalybuka/src/llvm.git/llvm-project/compiler-rt/lib/fuzzer /usr/local/google/home/vitalybuka/src/llvm.git/llvm-project/compiler-rt/test/fuzzer/FourIndependentBranchesTest.cpp -o /usr/local/google/home/vitalybuka/src/llvm.git/out/build-clang-none/projects/compiler-rt/test/fuzzer/Output/value-profile-set.test.tmp-FourIndependentBranchesTest
  not /usr/local/google/home/vitalybuka/src/llvm.git/out/build-clang-none/projects/compiler-rt/test/fuzzer/Output/value-profile-set.test.tmp-FourIndependentBranchesTest -seed=1 -use_cmp=0 -use_value_profile=1 -runs=100000000 2>&1 | FileCheck /usr/local/google/home/vitalybuka/src/llvm.git/llvm-project/compiler-rt/test/fuzzer/value-profile-set.test
  --
  Exit Code: 1
  
  Command Output (stderr):
  --
  clang-6.0: warning: argument unused during compilation: '-static-libstdc++' [-Wunused-command-line-argument]
  /usr/bin/ld: cannot find -lc++
  /usr/bin/ld: cannot find -lc++
  clang-6.0: error: linker command failed with exit code 1 (use -v to see invocation)



================
Comment at: lib/fuzzer/FuzzerInterface.h:25
 
+#pragma GCC visibility push(default)
+
----------------
this is header so it may have side effects. could you please use attribute instead of pragma?




Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D37631