[PATCH] D40845: [WebAssembly] COMDAT: LLD support

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added inline comments.


================
Comment at: wasm/InputFiles.cpp:271
+    if (!Comdat.empty() && Symtab->findComdat(Comdat) != this)
+      Seg->Discarded = true;
+  }
----------------
Can we check the comdats when the segment or function is first created to avoid two loops?

Maybe we could then avoid even adding the to the Functions or Segments list at all and just discard them?


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D40845