[PATCH] D40805: [RISCV] Support for varargs

Krzysztof Parzyszek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 10 11:31:55 PST 2018


kparzysz added inline comments.


================
Comment at: lib/Target/RISCV/RISCVISelLowering.cpp:719
+      SDValue Store =
+          DAG.getStore(Chain, DL, ArgValue, PtrOff, MachinePointerInfo());
+      cast<StoreSDNode>(Store.getNode())
----------------
kparzysz wrote:
> You could use MachinePointerInfo::getFixedStack instead of an empty pointer info to get more accurate aliasing.
Other than that, LGTM.


https://reviews.llvm.org/D40805





More information about the llvm-commits mailing list