[PATCH] D41687: [llvm-objcopy] Add support for input types and the -I and -B flags

Jake Ehrlich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 10 10:26:17 PST 2018


jakehehrlich added a comment.

I plan on adding a refactoring to use an InputReader and possibly a Writer object and detemplating Object to make the refactoring work. I think that's a) quite doable and b) a very good idea. I'm going to post the refactoring in another change and put this one on hold for a bit and then rebase the refactor into this change so there isn't one giant change all at once.



================
Comment at: test/tools/llvm-objcopy/binary-input-test.bin:1
+0000
----------------
jhenderson wrote:
> I don't think you meant to add this file?
uh crap my %p solution was wrong. Now I see that you commend on that. Whoops.


Repository:
  rL LLVM

https://reviews.llvm.org/D41687





More information about the llvm-commits mailing list