[PATCH] D41908: [X86][MMX] Add support for MMX zero vector creation

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: lib/Target/X86/X86InstrInfo.cpp:8964
       Ty = VectorType::get(Type::getInt32Ty(MF.getFunction().getContext()), 8);
+    else if (Opc == X86::MMX_SET0)
+      Ty = VectorType::get(Type::getInt32Ty(MF.getFunction().getContext()), 2);
----------------
craig.topper wrote:
> Do the test cases cover this?
No I don't think they do. Any suggestions on suitable tests? I'm a little unclear as to when this kicks in given that the zero registers are all flagged as isReMaterializable.


Repository:
  rL LLVM

https://reviews.llvm.org/D41908