[PATCH] D40845: [WebAssembly] COMDAT: LLD support

Nicholas Wilson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 10 06:17:40 PST 2018


ncw updated this revision to Diff 129267.
ncw added a comment.

Rebased as requested.

> Does this depend on https://reviews.llvm.org/D41390?

I did it this way round, because I thought https://reviews.llvm.org/D41390 was the less controversial, and hence would be applied first. I wanted to add the `Discarded` flag and behaviour, without having to wait for discussion of the COMDAT to grind on.

The COMDAT support here does depend on the Discarded flag added in https://reviews.llvm.org/D41390, so I think the order does make sense.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D40845

Files:
  test/wasm/Inputs/comdat1.ll
  test/wasm/Inputs/comdat2.ll
  test/wasm/comdats.ll
  test/wasm/relocatable.ll
  wasm/InputChunks.h
  wasm/InputFiles.cpp
  wasm/SymbolTable.cpp
  wasm/SymbolTable.h
  wasm/Writer.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D40845.129267.patch
Type: text/x-patch
Size: 16043 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180110/56f96a03/attachment-0001.bin>


More information about the llvm-commits mailing list