[PATCH] D41613: [ELF] - Do not use HeaderSize for conditions in PltSection.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 10 01:57:22 PST 2018


>> ruiu added a comment.
>>
>> Isn't it an ABI violation not to write the PLT header for PPC64? If so, we fix that ABI violation rather than "correctly" emitting ABI-violating executables.
>
>The PPC64 implementation is incomplete. Finishing it would be nice, but
>independent of this change.
>
>Without this change a target must set Target->PltHeaderSize to avoid
>having lld confuse the plt and iplt sections, which is not a good design
>IMHO.
>
>Cheers,
>Rafael

I would like to add here that even if it is ABI violation to not write PLT header (though I am not sure. Is it a violation
to do that if target implementation does not yet support lazy binding ?), it is still probably should be a violation to write
dummy PLT header?

So it seems to me that most correct ways is to finish imlpementation, but until that I would not write dummy PLT header too.

George.


More information about the llvm-commits mailing list