[PATCH] D35592: [WebAssembly] Remove duplicated RTLIB names

Derek Schuff via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 9 15:02:09 PST 2018


dschuff added a comment.

Coming back to this patch, in order to remove the tight coupling between the arrays in WebAssemblyRuntimeLibcallSignatures.cpp and the list of libcalls in the def file.

In https://reviews.llvm.org/D35522 we discussed changing the API of `TargetLoweringBase::getLibcallName()` and I experimented with that but it ended up being a more pervasive change than I expected, and I wasn't sure the result was any better than what we have now. So I updated this PR, and I still like it for the reasons I mentioned in the comments before, but happy to take more input now.


https://reviews.llvm.org/D35592





More information about the llvm-commits mailing list